Skip to content

Allow deploy of VRs on dedicated resources#9531

Open
GaOrtiga wants to merge 4 commits into
apache:mainfrom
scclouds:deploy_vr_dedicated_resources
Open

Allow deploy of VRs on dedicated resources#9531
GaOrtiga wants to merge 4 commits into
apache:mainfrom
scclouds:deploy_vr_dedicated_resources

Conversation

@GaOrtiga
Copy link
Copy Markdown
Collaborator

@GaOrtiga GaOrtiga commented Aug 14, 2024

Description

Currently, it is not possible to deploy VRs on dedicated resources, even if they are dedicated to the domain in which the VR will be created.

A new global configuration allowRoutersOnDedicatedResources has been created to allow VRs to be deployed on hosts, clusters, pods and zones that are dedicated to their respective domains.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

With the configuration marked as true:

  • I dedicated resources to the domain in which the VRs would be deployd and verified that the deploy worked normally.
  • I dedicated resources to an account in that domain and verified that I could not deploy VRs on these resources.
  • I dedicated resources to a different domain and verified that I could not deploy VRs on these resources.

I marked the configuration as false and verified that I could not deploy VRs on any of the dedicated resources.

DaanHoogland
DaanHoogland reviewed Aug 16, 2024
View reviewed changes
Comment thread engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java Outdated
@nicoschmdt nicoschmdt force-pushed the deploy_vr_dedicated_resources branch from 5da9945 to 7b05daf Compare February 5, 2025 16:13
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 6, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 6, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.10%. Comparing base (3166e64) to head (8b20abe).
⚠️ Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/cloud/capacity/dao/CapacityDaoImpl.java 50.00% 1 Missing and 1 partial ⚠️
...rc/main/java/com/cloud/deploy/FirstFitPlanner.java 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9531      +/-   ##
============================================
+ Coverage     18.01%   18.10%   +0.08%     
- Complexity    16607    16747     +140     
============================================
  Files          6029     6037       +8     
  Lines        542160   542938     +778     
  Branches      66451    66488      +37     
============================================
+ Hits          97682    98274     +592     
- Misses       433461   433616     +155     
- Partials      11017    11048      +31
Flag Coverage Δ
uitests 3.51% <ø> (-0.01%) ⬇️
unittests 19.26% <76.92%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 6, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12358

@nicoschmdt
Copy link
Copy Markdown
Contributor

nicoschmdt commented Feb 14, 2025

Hey @DaanHoogland, could we run the CI on this PR?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 15, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 15, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 16, 2025

[SF] Trillian test result (tid-12421)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58187 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9531-t12421-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.29 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 1.41 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 1.41 test_ipv4_routing.py
test_12_start_vm_multiple_volumes_allocated Error 20.01 test_vm_life_cycle.py

@nicoschmdt nicoschmdt self-assigned this Feb 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@nicoschmdt nicoschmdt force-pushed the deploy_vr_dedicated_resources branch from 7b05daf to e15e366 Compare May 6, 2025 20:21
@nicoschmdt
Copy link
Copy Markdown
Contributor

nicoschmdt commented May 6, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 6, 2025

@nicoschmdt a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 6, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13280

@DaanHoogland DaanHoogland added this to the 4.21.0 milestone May 7, 2025
@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 15, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@weizhouapache weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 10, 2025

@nicoschmdt can you look at the conflicts again?

@DaanHoogland DaanHoogland marked this pull request as draft October 10, 2025 08:50
@harikrishna-patnala harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025
@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026
@rajujith
Copy link
Copy Markdown
Contributor

rajujith commented Jan 13, 2026

@GaOrtiga Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

@GaOrtiga
Copy link
Copy Markdown
Collaborator Author

GaOrtiga commented Mar 12, 2026

@GaOrtiga Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

Hi, @rajujith, when testing this I had some ideas of possible improvements, which should be added to this PR, however, I have other obligations which take precedence over this PR, so I will leave it on draft until I can work on it again. When I'm back to working on it, I'll change it to the correct branch.

Thank you.

@GaOrtiga GaOrtiga force-pushed the deploy_vr_dedicated_resources branch from e15e366 to 2bc25d1 Compare April 20, 2026 17:57
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Apr 21, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 21, 2026

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 21, 2026

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17561

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Apr 24, 2026

@GaOrtiga can you check/fix the build failure.

@sureshanaparti sureshanaparti modified the milestones: 4.22.1, 4.23.0 Apr 24, 2026
@winterhazel
Copy link
Copy Markdown
Member

winterhazel commented May 25, 2026

@GaOrtiga could you have a look at the conflicts?

@GaOrtiga GaOrtiga force-pushed the deploy_vr_dedicated_resources branch from 2bc25d1 to e2197f0 Compare May 25, 2026 17:27
@GaOrtiga
Copy link
Copy Markdown
Collaborator Author

GaOrtiga commented May 25, 2026

@rajujith @sureshanaparti @winterhazel

Sorry for the delay, this was on my backlog.

I had to to some adjustments to address some use cases that were brought up, but now its ready for review/testing.

@GaOrtiga GaOrtiga marked this pull request as ready for review May 25, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@JoaoJandre JoaoJandre JoaoJandre approved these changes

Assignees

@nicoschmdt nicoschmdt

Labels

component:api

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

10 participants

@GaOrtiga @DaanHoogland @blueorangutan @nicoschmdt @rajujith @sureshanaparti @winterhazel @JoaoJandre @harikrishna-patnala @weizhouapache